Steven G. Johnson
Steven G. Johnson
Currently, Point – Point produces a Point, which seems wrong for the documented semantics.
It would be nice, in principle, to define chainrules for the chebpoly constructors, so that we support computation of sensitivities of e.g. polynomial evaluations to the *data* used to construct...
As I noted [here](https://discourse.julialang.org/t/lagrangian-function/38287/19?u=stevengj), it is pretty easy to compute Lagrange multipliers, given an optimum x computed by *any* optimization algorithm, by solving a small least-squares problem. Since people occasionally...
The `x_of_nans` function gives a `MethodError` for 0-dimensional arrays due to JuliaLang/julia#41643. A workaround is to use `map(Tf, x)` instead of `Tf.(x)`. Before this PR: ```jl julia> x_of_nans(fill(0.0)) ERROR: MethodError:...
The default test tolerances here seem wrong: https://github.com/JuliaDiff/ChainRulesTestUtils.jl/blob/6925da14c12e3d743c8d3620db8a8bee1433d5c3/src/testers.jl#L17 1. The default `rtol = 1e-9` assumes double precision. Better to follow `isapprox` here and use `sqrt(eps(float(T)))`? 2. By setting a nonzero...
@samuelcolvin mentioned that he thought Julia's JSON code is slow right now. I wasn't aware of any egregious performance problems, but it's true that it probably hasn't been much optimized....
Would be nice to use partr for multi-threading, so that multi-threaded Blosc becomes composable with other Julia multi-threaded code. We might be able to do something similar to FFTW/fftw3#175
Rather than declaring arguments (and `struct` fields) as `Vector{IntPoint}`, it would be more generic to allow `AbstractVector{IntPoint}`. This can still be passed to C libraries as long as it supports...
It looks like you are overloading `display` in order to customize output. This is the wrong way to do it — see the manual on [custom pretty printing](https://docs.julialang.org/en/release-0.6/manual/types/#Custom-pretty-printing-1). To customize...
It would be nice to have some more tutorial examples in this package, especially because the Gmsh API docs are so minimal. For example, one common desire is to be...