Stephen Toub

Rename `Exception<T>` and have non-generic base

1

The base class for Semantic Kernel exceptions is `Exception`. This is too general a name, even though it's part of the Microsoft.SemanticKernel.Diagnostics namespace. Once a developer imports the namespace, catch...

Guard ILogger logging with IsEnabled checks

6

### Motivation and Context Reduce overhead when logging disabled. ### Description When there's only a constant message, having a guard is less impactful. But if there are any arguments, without...

### Motivation and Context Minor cleanup. ### Description These are unnecessary. As I was reviewing through the code I happened to notice they were unused or had greater than required...

Clean up exposure and handling of CancellationToken

1

### Motivation and Context Clean up exposure and handling of CancellationToken in public APIs. ### Description - In public API, they should always be the last parameter (unless they can't...

### Motivation and Context A bit of cleanup for the `Score` and `ScoredValue` types. ### Description - Make them both readonly, removing the setters from properties - Give Score a...

Operators on ScoredValue produce inconsistent answers

3

`ScoredValue` contains both a `T` and a `double`. Its `==` and `!=` operators factor in equality of both the `T` and the `double`, but its `` operators only factor in...

Can we make MinHeap internal?

1

.NET added a `PriorityQueue` type to its core collections in .NET 6. Can we avoid making Semantic Kernel's `MinHeap` public? It can continue to use it internally when targeting netstandard2.0,...

**Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll...

Adopt TimeProvider abstraction when its ready

1

The DefaultHttpRetryHandler type defines IDelayProvider and ITimeProvider interfaces. The APIs these surface are fully covered by the new System.TimeProvider abstract type being introduced in .NET 8 but that will also...

### Motivation and Context Simplify/streamline ImportSkill ### Description `ImportSkill(object skillInstance, string skillName, ILogger log)` uses Enumerable.Select to enumerate a MethodInfo[], then uses Enumerable.Where to filter out nulls, then populates a...