Stephen Toub

Fix concurrency issues and double lookups in SkillCollection

1

### Motivation and Context Fix concurrency issues in SkillCollection and reduce overhead and duplication. ### Description If multiple threads concurrently call AddSemantic/NativeFunction, and the skill in question didn't yet exist,...

Potential concurrency bugs in FunctionsView

1

FunctionsView appears to be trying to be thread-safe, as its SemanticFunctions and NativeFunctions are both ConcurrentDictionary. However, in that case there are a couple of concurrency bugs lurking. First, while...

Semantic Kernel needs a consistent story around HttpClient

1

Some types create and destroy their own HttpClient{Handler} instances, which could lead to poor performance and port exhaustion if done too frequently. Some types optionally allow an HttpClient to be...

Clean up APIs that take both SKContext and ILogger/CancellationToken

1

Some APIs, e.g. Plan.InvokeAsync, accept optional SKContext, ILogger, and CancellationToken instances, e.g. ```C# public async Task InvokeAsync(SKContext? context = null, CompleteRequestSettings? settings = null, ILogger? log = null, CancellationToken cancellationToken...

Add support for multiple native function arguments

11

### Motivation and Context Move native functions closer to a normal C# experience. ### Description - Native skills can now have any number of string parameters, not just at most...

A few minor suggested tweaks to TrustAwareString

1

### Motivation and Context A few recommended tweaks after glancing at the new type. ### Description - Remove the static Empty property. Static Empty properties in .NET are expected to...

### Motivation and Context Make ContextVariables feel more like the dictionary it is. ### Description ContextVariables waddles like a dictionary and quacks like a dictionary but for some reason isn't...

ExceptionOnStartIsPropagated test failed in CI

4

## Build Information Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=232981 Build error leg or test failing: Microsoft.Extensions.Hosting.WindowsServiceLifetimeTests.ExceptionOnStartIsPropagated Pull request: https://github.com/dotnet/runtime/pull/84556 ## Error Message Fill the error message using [known issues guidance](https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssues.md#how-to-fill-out-a-known-issue-error-section). ```json { "ErrorMessage": "ExceptionOnStartIsPropagated",...

SeekableDeviceFileStreamStandaloneConformanceTests test failed with overlapped error in CI

2

## Build Information Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=530433 Build error leg or test failing: System.IO.Tests.SeekableDeviceFileStreamStandaloneConformanceTests.Write_Read_Success Pull request: https://github.com/dotnet/runtime/pull/97078 ## Error Message Fill the error message using [step by step known issues guidance](https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssues.md#how-to-fill-out-a-known-issue-error-section). ```json...

[browser][MT] various WebWorkerTest CI failures

15

## Build Information Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=517510 Build error leg or test failing: System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.ManagedDelay_ConfigureAwait_True Pull request: https://github.com/dotnet/runtime/pull/96605 ## Error Message Fill the error message using [step by step known issues guidance](https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssues.md#how-to-fill-out-a-known-issue-error-section). ```json...