semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Can we make MinHeap internal?

Open stephentoub opened this issue 2 years ago • 1 comments

.NET added a PriorityQueue<> type to its core collections in .NET 6. Can we avoid making Semantic Kernel's MinHeap<> public? It can continue to use it internally when targeting netstandard2.0, but when it eventually multitargets and/or builds for .NET 6+, it can just rely on the built-in implementation.

https://github.com/microsoft/semantic-kernel/blob/main/dotnet/src/SemanticKernel/Memory/Collections/MinHeap.cs

stephentoub avatar Apr 24 '23 13:04 stephentoub

@dluc make class internal. For more recent .NET version we should use PriorityQueue<>

dluc avatar Apr 26 '23 16:04 dluc