semantic-kernel
semantic-kernel copied to clipboard
Can we make MinHeap internal?
.NET added a PriorityQueue<> type to its core collections in .NET 6. Can we avoid making Semantic Kernel's MinHeap<> public? It can continue to use it internally when targeting netstandard2.0, but when it eventually multitargets and/or builds for .NET 6+, it can just rely on the built-in implementation.
https://github.com/microsoft/semantic-kernel/blob/main/dotnet/src/SemanticKernel/Memory/Collections/MinHeap.cs
@dluc make class internal. For more recent .NET version we should use PriorityQueue<>