Stephen Toub
Stephen Toub
https://github.com/dotnet/runtime/pull/75373#discussion_r967650446 What is the impact if we don't do this? Does it prevent roundtripping / another tool deserializing tar archives produced by TarWriter? There's a high liklihood file names will...
> For formats other than Pax, containing a name or some other field (such as LinkName) that contains non-ASCII characters, those characters will be garbled as shown in the picture...
>> they'll produce garbage names in the file system? > Right Then this needs to be fixed for 7.0. > This might be as easy as replacing Encoding.ASCII for Encoding.UTF8...
Also on PRs in main, e.g. https://github.com/dotnet/runtime/pull/75318/checks?check_run_id=8279068492 https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-75318-merge-3cb5f6cbea0a472187/JIT.HardwareIntrinsics.General.Vector256/1/console.f2f14acf.log?helixlogtype=result ``` > /datadisks/disk1/work/B89F09F9/w/BCB50A0C/e/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro/Vector256_1_ro.sh Expected: True Actual: False Stack Trace: at JIT_HardwareIntrinsics._General_Vector256_1_Vector256_1_ro_Vector256_1_ro_._General_Vector256_1_Vector256_1_ro_Vector256_1_ro_sh() at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor) at System.Reflection.MethodInvoker.Invoke(Object...
And: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-75212-merge-244fe847cfa44a98ac/JIT.HardwareIntrinsics.General.Vector256/1/console.480092cf.log?helixlogtype=result https://dev.azure.com/dnceng-public/public/_build/results?buildId=10368&view=ms.vss-test-web.build-test-results-tab&runId=209152&resultId=102987&paneView=dotnet-dnceng.dnceng-anon-build-release-tasks.helix-anon-test-information-tab
/azp run runtime-extra-platforms
> We should try to get it into 7.0 as mentioned in the issue. This hasn't moved in 10 days. What's the plan?
> Duplicate of https://github.com/dotnet/runtime/issues/75900 I closed the other one... somehow it got opened twice.
> What's the anticipated behavior around in-place reversals? That it works, i.e. that it's semantically equivalent to: ```C# for (int i = 0; i < source.Length; i++) { destination[i] =...
My hope actually is that this code completely goes away, with the new APIs being added in https://github.com/dotnet/runtime/pull/75012. Maybe we could focus on making those as efficient as possible and...