Stephen Toub
Stephen Toub
That's up to @kouvel.
In your code, if the byte/short/etc. is just before memory that's not accessible, such that extending by a few more bytes steps over that boundary, this could AV / seg...
> It seems that all architectures that .Net currently supports have hardware support, so this is a non-issue. My point was we're not going to add a temporary implementation based...
> What do you think? It's trivial for someone to implement those themselves in terms of the proposed ones. That said, bool could be a reasonable addition, just because it's...
> Oh I thought something like that always has to be strictly re-reviewed. It does if it were to be included. > I ask because I plan to implement this...
I wonder if the similarity between `Path.GetTempPath()` and `Path.GetTempDirectoryName()` would lead someone to call the latter when they'd intended to call the former (e.g. "Hmm, I need to put something...
Are all of these changes necessary in order to successfully compile? If yes, this seems like a fairly significant breaking change, no? Or are these changes only necessary because of...
This actually found a pre-existing bug. This: ```C# Console.WriteLine(new[] { "1", "2", "3" }.AsSpan().LastIndexOfAny("4", "5", null)); ``` fails with: ``` Unhandled exception. System.NullReferenceException: Object reference not set to an instance...
Failure is https://github.com/dotnet/runtime/issues/73247
> iirc @stephentoub asked me for that in the past. Yup: https://github.com/dotnet/BenchmarkDotNet/issues/1774