runtime icon indicating copy to clipboard operation
runtime copied to clipboard

Update for recent compiler changes for ref fields

Open cston opened this issue 2 years ago • 3 comments

See https://github.com/dotnet/roslyn/pull/62886.

cston avatar Aug 05 '22 15:08 cston

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis See info in area-owners.md if you want to be subscribed.

Issue Details

See https://github.com/dotnet/roslyn/pull/62886.

Author: cston
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

msftbot[bot] avatar Aug 05 '22 15:08 msftbot[bot]

Are all of these changes necessary in order to successfully compile? If yes, this seems like a fairly significant breaking change, no? Or are these changes only necessary because of related places we're already using scoped?

stephentoub avatar Aug 05 '22 16:08 stephentoub

Are all of these changes necessary in order to successfully compile?

Yes, these are changes needed to compile successfully. These are typically methods that have a ref parameter and another ref parameter of a ref struct type.

cston avatar Aug 05 '22 16:08 cston

I don't see any failures in the arm64 test. Looks like an infrastructure issue.

[15:05:31.5263400] 2022-08-12 15:05:31.506 System.Runtime.Tests[16226:178107346] Tests run: 49815 Passed: 49582 Inconclusive: 0 Failed: 0 Ignored: 137 Skipped: 96

AaronRobinsonMSFT avatar Aug 13 '22 02:08 AaronRobinsonMSFT