Stefan Horning

Results 19 comments of Stefan Horning
trafficstars

Yes, if there is already a place to do this you are probably right. Currently don't really remember what the motivation was to add this (over a year ago), might...

with 2.4.0 already released by now, when will the 3.2.0 release follow?

PR is ready to be merged now (from my side).

Latest change is still green with recent CI. So I guess this can be merged now?

Looks like CI/bots got confused by the rebase?

rebased on latest `main` as requested, also squashed irrelevant commits.

Tests failed to create a VPC due to AWS limits (error unrelatd to my changes).

Still necessary and swimmadude66's fix still works, line has moved to `3774` in the meantime. Surprised this still wasn't fixed!

Also still having this issue, even with latest version. This has been there for a while now, see https://github.com/amplify-education/serverless-domain-manager/issues/335 At least with the `http` api type I never got it...