community.aws icon indicating copy to clipboard operation
community.aws copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Allow to provide instance requirements options to ASG module

Open stefanhorning opened this issue 2 years ago • 44 comments

... to let AWS pick instance types based on machine specs.

SUMMARY

Just allows to pass through more arguments in the mixed_instances_policy section, namely the one for specifying instance requirements (instead of providing specific instance types).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_asg

stefanhorning avatar Dec 10 '21 13:12 stefanhorning

PR is ready to be merged now (from my side).

stefanhorning avatar Dec 13 '21 12:12 stefanhorning

cc @garethr @jillr @markuman @s-hertel @tremble click here for bot help

ansibullbot avatar Feb 09 '22 10:02 ansibullbot

Build succeeded.

softwarefactory-project-zuul[bot] avatar Feb 09 '22 10:02 softwarefactory-project-zuul[bot]

Latest change is still green with recent CI. So I guess this can be merged now?

stefanhorning avatar Feb 10 '22 08:02 stefanhorning

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

softwarefactory-project-zuul[bot] avatar Feb 28 '22 08:02 softwarefactory-project-zuul[bot]

There was an error handling pipeline event 4d0d2b0a-3461-4c22-910a-93925224aff5.

azure-pipelines[bot] avatar Feb 28 '22 08:02 azure-pipelines[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Feb 28 '22 09:02 softwarefactory-project-zuul[bot]

Looks like CI/bots got confused by the rebase?

stefanhorning avatar Mar 01 '22 07:03 stefanhorning

recheck

marknet15 avatar Mar 09 '22 19:03 marknet15

Build failed.

softwarefactory-project-zuul[bot] avatar Mar 09 '22 20:03 softwarefactory-project-zuul[bot]

recheck

mandar242 avatar Mar 29 '22 22:03 mandar242

Build failed.

softwarefactory-project-zuul[bot] avatar Mar 30 '22 00:03 softwarefactory-project-zuul[bot]

Hi @stefanhorning, thank you for working on this! Could you rebase your branch with main https://github.com/ansible-collections/community.aws?

With recent merge of https://github.com/ansible-collections/community.aws/pull/1036, integration tests TIMED_OUT issue should be resolved now :)

As this would help us mark all issues related to ec2_asg here https://github.com/ansible-collections/community.aws/issues/895

mandar242 avatar Apr 01 '22 19:04 mandar242

rebased on latest main as requested, also squashed irrelevant commits.

stefanhorning avatar Apr 04 '22 08:04 stefanhorning

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 04 '22 09:04 softwarefactory-project-zuul[bot]

Tests failed to create a VPC due to AWS limits (error unrelatd to my changes).

stefanhorning avatar Apr 04 '22 09:04 stefanhorning

recheck

mandar242 avatar Apr 06 '22 15:04 mandar242

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 06 '22 16:04 softwarefactory-project-zuul[bot]

recheck

mandar242 avatar Apr 06 '22 16:04 mandar242

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 06 '22 17:04 softwarefactory-project-zuul[bot]

Thank you @stefanhorning, minor changes that are causing CI failure

https://github.com/ansible-collections/community.aws/pull/831/files#diff-1a33a4359f835bab9c605061886c5d1bfb6d0d2eb377f1fbf8f19720360e476dR488-R490 (create_update_delete.yml Lines 488-490) should be something like

"output.mixed_instances_policy.launch_template.overrides | length == 2"
"output.mixed_instances_policy.launch_template.overrides[0].instance_type == 't3.micro'"
"output.mixed_instances_policy.launch_template.overrides[1].instance_type == 't2.nano'"

mandar242 avatar Apr 06 '22 19:04 mandar242

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 07 '22 07:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 07 '22 12:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 07 '22 14:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 08 '22 10:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 08 '22 11:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 12 '22 15:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 13 '22 07:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 13 '22 09:04 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Apr 13 '22 11:04 softwarefactory-project-zuul[bot]