Jan Stanstrup

_From @jotsetung on October 19, 2017 17:1_ Are you planning to add each resource (i.e. its data) to the package?

That was my plan if it is feasible without violating licenses. Parsing for example the json from lipidblast is very slow and people need to download a 1.6GB file. Whereas...

_From @jotsetung on October 20, 2017 6:49_ The idea is to match compounds by (adduct) m/z, right? So you'll have some columns (like mass, id and name) that are common...

Right. I was hoping not to have DB specific columns to be able to easily mix and match though. What do you mean my hide internals?

_From @jotsetung on October 20, 2017 7:55_ Example to explain the *hide the internals*: this is the concept we were following for/in the `AnnotationFilter`, `ensembldb` packages: + define a common...

_From @jotsetung on October 20, 2017 8:8_ Regarding HMDB parsing: I did implement a simple parser to extract fields from HMDBs xml file(s): https://github.com/jotsetung/xcmsExtensions/blob/master/R/hmdb-utils.R use whatever you want/need.

Yeah I say that just now when poking around your repo. I actually also wrote one some years ago I was planning to add. I have a suspicion that yours...

If you don't enforce column names in databases won't it become difficult to mix them if for example you want data from HMDB and lipidmaps for the annotation?

_From @jotsetung on October 20, 2017 9:12_ Re: code from `xmcsExtensions`, please copy what you need - I wan't update/use that package anymore. Your's will be much better! Re: enforcing...

_From @jotsetung on October 20, 2017 12:43_ Are you already working on the HMDB import function? Otherwise I could do that do start getting my hands dirty...