Markus Staab
Markus Staab
Which problem is this PR trying to solve?
@kukulich just found this PR. Is it still relevant? Is there a concrete problem beeing solved here (it looks like its a performance improvement)?
@ondrejmirtes I think getting this merged would help a lot of non-strict codebases, because `in_array` is usally used a lot
> What I'd like here too is a new PHPStan rule in Api namespace that would check this too. @ondrejmirtes would the new rule check the generic template type of...
@rvanvelzen may I ask you for your opinion on these conditional types involved, as I think you are the expert :)? --- I am wondering why we resolve `@param` differently...
@VincentLanglet I think motivation is the comments in https://github.com/phpstan/phpstan-src/commit/ee737e6df6cc73c845515ffb863aa5c62b59a34f#commitcomment-138984141
@ondrejmirtes what do you think about all these > Comparison operation "
I think the errors we see in CI make sense. not sure what we can/should do about them. it make sense to check for php-versions smaller then the composer.json declared...
@ondrejmirtes keeping this one up2date is a bit cumbersome, because of the added composer dependency (and the conflicts I need to resolve on every other dependency update). would be great...
thanks for the feedback. > If it's null, resolve it to a single number in PHPStan 1.x (according to config.platform.php in composer.json), and to min/max structure with bleeding edge (according...