Markus Staab

Sure, lets see how it goes. Alternatively/Additionally I will look into a narrowed PhpVersion based on scope like we brainstormed in https://github.com/phpstan/phpstan/discussions/4212#discussioncomment-8803159

I think all the feedback is adressed

squashed, rebased against 1.11 and re-targetted the PR.

All feedback should be addressed. > Yeah, please remove the `-1`. ~~because of this change we are now seeing a lot of errors in the test-suite, e.g.:~~ > Comparison operation...

rebased for 2.x in https://github.com/phpstan/phpstan-src/pull/3584

I think this one is ready for a review

@ondrejmirtes here you are

(I need to verify on a different computer with PHP 7.2 installed whether the test is working as intended)

reverted the previous test commit. I thnk there is no type inference difference to observe, because phpstan internally works with the same "wrong" constant value as the code beeing analyzed...

I got one idea for which I am not sure whether its worth testing. the type inference might be different when we define the constant in bootstrap with a integer...