Sebastian Szczepański

Results 15 comments of Sebastian Szczepański

Do you want me to take a look at it? If it's a small change and you already know how to fix it, it would be great as I wouldn't...

One more thing - do you have any idea for better event name mapping? To be honest I don't like it much.

> @imbhargav5 @sszczep Oh forgot to mention, it would be great if the documentation (useFullscreen.md) could be updated with the new API. I'll work on docs. Please think about that...

@imbhargav5 could you reopen? I can't push more commits. I wrote new documentation, however, I couldn't check how it renders. Should be fine though. edit: Oh, I see that once...

I don't think external polyfill is feasible, couldn't find any. I think the only solution is to include it using script tag (I really don't like that, what if there...

I will make further adjustments (better error handling etc.) and create a PR. We should talk about the API though. To be honest I would return only isFullscreenAvailable, isFullscreenEnabled, enableFullscreen,...

> > I wouldn't return the fullscreenElement. It requires one more state in hook and I can't find any use case for it. > > > > Fine by me....

Wow, haven't expected such a fast reply. So i flashed the CRC firmware, it gets detected in `lsusb`: `0d28:0204 NXP ARM mbed`. It also gets picked up by `pyocd`: ```...

That's a massive update. Unfortunately I had to abandon my project for the time being, but I will make sure to check it out. Thanks!