rooks
rooks copied to clipboard
Rewrite useFullscreen hook
solves #1235
@imbhargav5 could someone takeover testing that hook? Removed test suite for now.
@sszczep is attempting to deploy a commit to the Rooks Team on Vercel.
A member of the Team first needs to authorize it.
Codecov Report
Merging #1241 (23be8b2) into main (c394747) will decrease coverage by
2.16%
. The diff coverage is43.98%
.
:exclamation: Current head 23be8b2 differs from pull request most recent head 8e1d589. Consider uploading reports for the commit 8e1d589 to get more accurate results
@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
- Coverage 93.75% 91.59% -2.17%
==========================================
Files 73 73
Lines 4470 4471 +1
Branches 767 756 -11
==========================================
- Hits 4191 4095 -96
- Misses 279 376 +97
Impacted Files | Coverage Δ | |
---|---|---|
packages/rooks/src/hooks/useFullscreen.ts | 47.38% <43.98%> (-36.14%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
rooks | ✅ Ready (Inspect) | Visit Preview | Aug 17, 2022 at 0:33AM (UTC) |
This looks great. Any thoughts @qqpann ? If it looks good to you, I will add tests and get it shipped this weekend.
One more thing - do you have any idea for better event name mapping? To be honest I don't like it much.
@sszczep @qqpann Awesome work! I will take a look tomorrow.
@imbhargav5 @sszczep Oh forgot to mention, it would be great if the documentation (useFullscreen.md) could be updated with the new API.
@imbhargav5 @sszczep Oh forgot to mention, it would be great if the documentation (useFullscreen.md) could be updated with the new API.
I'll work on docs. Please think about that event name mapping. We also need unit tests
@imbhargav5 could you reopen? I can't push more commits.
I wrote new documentation, however, I couldn't check how it renders. Should be fine though.
edit: Oh, I see that once merged, It's not possible to push more commits and I need to create a new PR. Which branch should I fork? I see that alpha does not exist anymore
@sszczep Can you just create a new PR for this to main
?