Peter Turek

Results 16 issues of Peter Turek

Hello, I would like to offer you library which helps you observe some standards. As you can see I added 4 commits: 1. just added library to project 2. added...

| Q | A | ------------- | --- |Description, reason for the PR| These methods were absolutely same |New feature| No |[BC breaks](https://docs.shopsys.com/en/latest/contributing/backward-compatibility-promise/)| Yes |Fixes issues| ... |Have you read...

| Q | A | ------------- | --- |Description, reason for the PR| On project has happened that country is not filled but [twig template expected country is always filled](https://github.com/shopsys/shopsys/blob/master/packages/framework/src/Resources/views/Admin/Form/deliveryAddressListFields.html.twig#L31)...

DX & Refactoring

| Q | A | ------------- | --- |Description, reason for the PR| If I understand elastic structure right, we use `_id` and `id` where `_id` comes [from array index](https://github.com/shopsys/shopsys/blob/16da913a4dab9cef20132520bfd3c5d384972bf7/packages/framework/src/Model/Product/Elasticsearch/ProductExportRepository.php#L154)...

| Q | A | ------------- | --- |Description, reason for the PR| After upgrading javascript codes disable loaderElement will not work with value null, so I recommend turning it...

| Q | A | ------------- | --- |Description, reason for the PR| When you change something in javascript file and run `php phing eslint-check-diff` that doesn't return anything. Adding...

In Backlog

| Q | A | ------------- | --- |Description, reason for the PR| Sometimes developers need to remove columns from vendor because they are unnecessary. Now after use `@RemoveColumns(propertyNames={"propertyName"})` will...

Status: on hold
In Backlog

| Q | A | ------------- | --- |Description, reason for the PR| Next phase of upgrade yaml standards. |New feature| Yes |[BC breaks](https://docs.shopsys.com/en/latest/contributing/backward-compatibility-promise/)| No |Fixes issues| closes #199 |Have...

In Backlog

### What is happening On one of project, I noticed that we have stored transport and payment in order https://github.com/shopsys/shopsys/blob/master/packages/framework/src/Model/Order/Order.php#L64-L78 and orderItem https://github.com/shopsys/shopsys/blob/master/packages/framework/src/Model/Order/Item/OrderItem.php#L120-L134. They are same so I don't get...

DX & Refactoring
In Backlog

| Q | A | ------------- | --- |Description, reason for the PR| Hello, I recommend you restrict robots on how many requests can ask from eshop. These changes are...

In Backlog