Stanislav Sinyagin

Results 31 comments of Stanislav Sinyagin

net.Socket is not sending "end" event on error. It sends "close" in both error and non-error cases, and that's when you need to emit `esl::end` I'll send a PR

also a branch to fix it in 1.2.1: https://github.com/voxserv/node-esl/tree/v1.2.1-bugfix

danke, ich werde beim Hersteller melden.

welche BIOS Version war mit der Fehler?

hier ist ein Antwort vom Hersteller: I just tried installing the OS using your ISO (https://github.com/ssinyagin/pcengines-apu-debian-cd/releases/download/9.1-20170801/debian-9.1-amd64-CD-1.iso) on an apu2 with the 4.6.9 coreboot BIOS. dd the ISO to an USB...

come on, it's a one-liner patch, and you have the PR in two branches already

and this PR is actually against v1.x branch

seems like you're expecting connection::close while the socket is still alive. With my patch, the close event comes when the socket is done.

I will re-write your patch, I don't like how you've done it :)