node-esl icon indicating copy to clipboard operation
node-esl copied to clipboard

Published 20 hours ago • verified publisher icon englercj

Issue #84 -- emit esl::end on socket::close

Open ssinyagin opened this issue 5 years ago • 6 comments

net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.

ssinyagin avatar Jan 10 '20 10:01 ssinyagin

If you rebase this branch to the latest, it should run CI so we can check if it passes.

englercj avatar Jan 11 '20 18:01 englercj

We think we are facing the same issue. The TCP connection was closed and the application does not receive any signal. Can we do something to help fixing the problem?

david-goncalves avatar Aug 05 '20 12:08 david-goncalves

A PR on the latest v1 branch with these changes that pass CI would allow me to merge it in.

englercj avatar Sep 01 '20 22:09 englercj

come on, it's a one-liner patch, and you have the PR in two branches already

ssinyagin avatar Sep 02 '20 06:09 ssinyagin

and this PR is actually against v1.x branch

ssinyagin avatar Sep 02 '20 06:09 ssinyagin

Hello @englercj, does it possible to merge this PR?

blerest avatar Jul 01 '22 08:07 blerest