Sebastian Schuberth

Results 1522 comments of Sebastian Schuberth

@nnobelis are you aware of any updates on the FOSSID side?

Theoretically, another option would be to make `sourceLocation` a `List` (where by convention the `path`s all must be the same; but I don't like this potential source of inconsistencies too...

As a semi-related question, do you know what they keys and values in `local_file` are? They seem to be lines numbers, but of what? Local vs matched file? Also, if...

> Yes keys and values are always the same, this is a ugliness that FossID had in other responses too. > They represent the matched lines in the local file...

> In `mirrorFile`, you get the matched lines in the snippet. How do you then know which line number in the `localFile` matches which line number in `mirrorFile`?

Hmm, so you saying that FossID does *not* know that line 25 on the left corresponds to line 276 on the right? How does the view look like initially, before...

Ok, here's a thought: Do we even care about the local location of the snippet in our / the scanned code? Or is it enough to know about the the...

> > If we'd want to capture `localFile`, too, then I believe the data model needs to be changed. > > In which way ? I was mislead, I forgot...

I lost a bit track of this issue, but wanted to note that by now we have https://github.com/oss-review-toolkit/ort/pull/9024. Does that somehow help to resolve this issue, @nnobelis?

> hopefully it will be better when FossID change it's API to an OPENAPI-compliant one. Has this issue been reported to FossID?