Sebastian Schuberth

Results 1514 comments of Sebastian Schuberth

I'd like to see `hyperv` provider support, too. Any hints as to what is needed to implement that?

Actually, at least in Firefox I thought this feature was already present. Firefox comes with a built-in "Subscribe to this page" button (![2017-04-19_161605](https://cloud.githubusercontent.com/assets/349154/25184741/993e04f0-251b-11e7-8edb-a6fe09299238.png)) which forwards to a page to select...

Oh, that's unfortunate to hear, about the API change. I found the custom actions to be very useful. Does the new API maybe support modifier keys in addition to left...

Personally, I feel that any *write* operations to the Git repository (like "updating" / "moving" a remote tag by deleting and recreating it) should be out of scope of this...

AFAIU it's not this action that tags, but the action gets trigger on a tag created / pushed by the user. And that's exactly how it should be, IMO.

Sounds a bit as if https://github.com/softprops/action-gh-release/pull/188 would implement that.

But that's the whole point: We do not want to (re-)use the existing `androidTest` source set as that is often already used for functional / instrumentation tests, and unit tests...

Looking a bit deeper into it, it seems odd that `getRepositoryForGerritProject()` returns an `Optional`, but on the other hand writes an error if no repository is found. Shouldn't the caller...

Ah, thanks, #76 is indeed related. But in my case, I would be even fine with *not* being able to see the diff. I just want to be able to...

To be honest, I did not try after getting the "No repository found for Gerrit project" error in the UI. Maybe voting would still be accessible in the UI, though....