Sebastian Schuberth

Results 1446 comments of Sebastian Schuberth

> The labels idea is interesting BTW, not directly excluding / including paths, but first labeling them, and then deciding what to do with the labels, resembles a bit [ClearlyDefined's...

Note that Ruby in the Docker image is not used for Bundler project analysis (we use JRuby for that), but only to run other PMs implemented in Ruby (I believe...

> I wonder whether we could get rid of Ruby completely, and exclusively use JRuby (i.e. its CLI) to run Cocoapods... I believe that's not going to happen any time...

In particular, this logic should be reviewed: https://github.com/oss-review-toolkit/ort/blob/bca951028d4b90692111d2311a6b3e589dd5090c/analyzer/src/main/kotlin/PackageManager.kt#L194-L201

To me, this reads as if this option works very different compared to options of the same name in other tools, e.g. `ScannerConfiguration.skipExcluded`: Instead of configuring whether analysis should be...

I think the behavior is indeed correct, but the naming / docs are partly misleading. For example the comment at https://github.com/oss-review-toolkit/ort/blob/c07420d429b40a418e20d46d19284a5b34606c93/model/src/main/kotlin/config/RepositoryConfiguration.kt#L41-L46 says "Note that excluded parts will still be analyzed"...