gerrit-intellij-plugin
gerrit-intellij-plugin copied to clipboard
Clarify how to work on remote-only Gerrit projects
After reading the README.md it's still unclear to me whether it's possible to review / vote on Gerrit changes whose project I have not cloned to a local Git repository (and thus have also not configured them in IntelliJ).
The REDAME.md says "By default, you will only see changes to Git repositories that are configured in the current project of your IntelliJ IDE". Ok, but how do I configure the non-default case then?
Whatever I tried, when selecting a change in the Gerrit view for which I have no local project set up, I get the "No repository found for Gerrit project" error. But why is that even required if all I want is to vote on a change and submit it?
@uwolfer Could you please clarify on that?
Looking a bit deeper into it, it seems odd that getRepositoryForGerritProject() returns an Optional<GitRepository>, but on the other hand writes an error if no repository is found. Shouldn't the caller of getRepositoryForGerritProject() decide whether the Optional<GitRepository> is actually mandatory in its context, and only then write an error at the caller level?
This is related to #76. It is not possible to view diffs of non-checked-out projects. You can only view it in list an execute some actions against it.
I'll clarify this in README.
Ah, thanks, #76 is indeed related. But in my case, I would be even fine with not being able to see the diff. I just want to be able to vote on a change and submit it. That should be much easier to implement that allowing to really review the change by displaying the diff.
I think voting is already possible without checking it out?
To be honest, I did not try after getting the "No repository found for Gerrit project" error in the UI. Maybe voting would still be accessible in the UI, though. I need to check.