Sean Owen comments

Results 245 comments of


                                            Sean Owen

java.lang.ClassCastException in very specific case on compiled ObjIntMap<String>.keySet().retainAll(...)

Yeah, that explains the correctness problem in Oryx. For now I've unfortunately switched to eclipse collections even though it's a bit slower.

RuntimeError: Placeholder storage has not been allocated on MPS device!

I think that's not really something in scope for this project, and this doesn't seem related to Dolly directly. Maybe someone has an idea; we can leave open for a...

SQLDatabase : Remove set search_path (or rewrite it)

I'm hitting this regularly too and applying the workaround, but would love to see it fixed. FWIW this syntax does not work with Spark SQL either.

SQLDatabase : Remove set search_path (or rewrite it)

Set ._schema=None

SQLDatabase : Remove set search_path (or rewrite it)

It looks like this was since resolved. See the code now: https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/utilities/sql_database.py#L389 It does selectively change this statement based on the dialect. You shouldn't have to set "None" anymore

[WIP] docs: restructure the docs index page

Looks good - ideally post a little before and after screenshot (or, just after)

[SPARK-47043][BUILD] add `jackson-core` and `jackson-annotations` dependencies to module `spark-common-utils`

I think this change itself is fine, and indeed technically correct. Not sure if we want to make lots of changes like this, but the occasional targeted one seems OK.

[SPARK-47042][BUILD] add missing explicit dependency 'commons-lang3' to the module 'spark-common-utils'

Likewise i think this is OK. We're not adding a direct dependency because it's a transitive dependency, but because it is used directly in the module.

[SPARK-46912] Use worker JAVA_HOME and SPARK_HOME instead of from submitter

Hm, how does JAVA_HOME get from the 'submitter' - what do you mean, the application submitter? but the worker is already running by that point

[SPARK-45527][CORE] Use fraction to do the resource calculation

No, he's asking why it's open vs the 3.5 branch not master. It is not going into master and so is not to be back ported either. The main reason...