Sean Owen

Results 245 comments of Sean Owen

Hm, I don't think it's quite that simple unfortunately - it causes some test to fail. I'm not totally sure why. It seems like building an Array this way doesn't...

We still want to merge this right?

Let me call in @zhengruifeng for a look at this too. I think it's pretty good

I think it looks good. There are 'failing' tests but it looks like a timeout. I'll run again to see if they complete. Anyone know about issues with the builder...

I would say no to this change. It adds complexity, and is quite specific to your deployment use case, where you want to allow users a lot of control to...