Sean Owen

Results 245 comments of Sean Owen

That sounds like a problem with the PNG file or the library that reads it; this library does not read images itself. Can you supply an example? otherwise, no way...

I don't think so; that part of the code does not allocate memory. Still need more info, like an example file. Or your heap dump stats. This can't be an...

It could be that the uploaded image is very large, which would put memory under pressure. Are you trying to say that this is the site that is _running a...

Oh I totally ignored that, it's not a barcode? surely this isn't what you're feeding to the library. But, sure, that's a huge image with no barcode in it. It's...

Well, huge relative to what? normal input to the library, certainly. The library handles this image fine as far as I can tell -- does take a long time to...

I disagree - you can make the best code run arbitrarily slow with enough input. That's why I'm trying to distinguish between a simple "I'd like this to use less...

Yeah I see something similar in a profiler - it's creating a whole lot of objects for sure, though they seem to be garbage-collectable. Still that can cause OOM if...

https://github.com/zxing/zxing/commit/78c2a9c4401e166be22ba1483cc1c7d090bdf8b8