Srivats Venkataraman
Srivats Venkataraman
Hi, Would it be ok/possible for me to work on the save chat functionality?? Or is the google team already working on it?
Hi, any idea or pointers on how to fix this: ``` The following TestFailure was thrown running a test (but after the test had completed): Expected: throws Actual: Future from:...
Oh so the changes in the PR is incorrect? Or something else needs to change?
Understood let me look at the code and see where the initCompleted is still be called in the test and remove those... Last I checked wasn't able to find any
Yes its ready for review looks like I might need to fix the conflicts which I will get to
I made the changes based on what was put in the issue... What I got from it was since the logic has been moved outside the package the code for...
Thank you, I will work on it with the directions provided and update the PR
Is it ok if I close this PR and open a new one?
> @srivats22 What would the goal of doing that be? Making it harder to find all the review context makes continuing the review much harder. Oh ok no worries I...
> From triage: @srivats22 Are you still planning on updating this PR based on the review feedback? Hi, yes I am still working on it... I had posted a question:...