Sam Ritchie

Results 356 comments of Sam Ritchie

@alfredwassermann I'm closing this, as I have a better understanding now of the issues involved! I have an idea about Canvas that I'll submit as a PR as well, so...

@ChristopherChudzicki we might be done with this, yeah?

Thank you for digging into these issues! I am swamped with some work that uses this code, so I won't have time to get to these for a while. Hopefully...

I suspect this can be closed now, as there is no longer a commons-math dep?

@ChristopherChudzicki we could also remove `rootProps` handling in the Mathbox component if you like and delegate it all to a new `Root` component: https://github.com/ChristopherChudzicki/mathbox-react/blob/main/mathbox-react/src/components/Mathbox.tsx#L52...

@ChristopherChudzicki okay, here we go! First quick note: I loaded up your story with live position and proxy=true and it looks pretty good to my eye. What do you think...

2. I'm not sure what I'm looking at in the story that's related to this PR! I am becoming more attracted to the idea of components that exist only to...

Yeah, not sure how we'd cache across serialization boundaries. This is a strange one. I don't have time to dive deep on this fix, but even erroring out with a...

I guess the outer serialization has access to the source code on the inner serialization, and could just substitute that in instead? Brainstorming from the phone here.