abseil-py icon indicating copy to clipboard operation
abseil-py copied to clipboard

Add default known_only to parse_flags_with_usage

Open sritchie opened this issue 5 years ago • 4 comments

This would allow users to take advantage of the error handling here while still being able to pass custom options on to FLAGS.

An alternative approach would just pass all kwargs along; but there's only one and this allows the docstring to stick here as well.

sritchie avatar Nov 06 '19 17:11 sritchie

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Nov 06 '19 17:11 googlebot

@googlebot I signed it!

sritchie avatar Nov 06 '19 17:11 sritchie

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Nov 06 '19 17:11 googlebot

Makes sense. Could you please add a unit test, it will need similar setup as this one

yilei avatar Nov 06 '19 19:11 yilei