Ryan Liptak

Results 617 comments of Ryan Liptak

Nice, node's implementation seems pretty complete but it makes heavy use of regex which might be hard/impossible to translate to Lua patterns.

Potentially, just note that `num ;` refers to an arbitrarily-sized semi-colon delimited list of numbers. That comment also seems to be missing `ESC [ ? num ; modifier letter` (not...

Relevant `luv` code: https://github.com/luvit/luv/blob/master/src/thread.c#L54-L106

Here's the commit where they diverged: https://github.com/luvit/lit/commit/27a3d962e1fa271df40271c5d4fe1dc9bc62c8c9

Seems like `uv.fileno` is returning nil here: https://github.com/luvit/luvit/blob/f31d24397f679681b6dc927a731f8f572a7f1c5e/deps/pretty-print.lua#L302 Not sure why that would be, or how the `out` parameter could possibly have an effect. From [the `fileno` docs](https://github.com/luvit/luv/blob/master/docs.md#uvfilenohandle): > Gets...

Works as expected for me on Windows. Maybe it's a firewall issue of some sort? What happens if you run `luvit tests/test-http-client-server.lua` inside a cloned luvit repo?

With this breaking change, I think it might also be worth re-evaluating relative requires, as they won't behave as expected with luvit-loader. See: - https://github.com/luvit/lit/pull/191#issuecomment-241087090 - https://github.com/lua/lua/blob/5.1.x/src/loadlib.c#L454-L461 That is, relative...

Also, feel free to [use the luvit-loader require tests I adapted for luver](https://github.com/squeek502/luver/blob/master/tests/test-require.lua) (it's mostly the same as the Luvit require tests, with a few extra tests). The method I...

Here's the error I'm getting on Windows when doing `make test`: ``` luvit-loader>make test "Testing luvit" Uncaught exception: ...\luvit-loader\deps\dns.lua:101: attempt to redefine 'ERROR_SUCCESS' at line 7 stack traceback: [C]: in...

The Windows build error was due to the require auto-register in Luvi + require being included through package.lua: https://github.com/luvit/luvi/blob/master/src/lua/luvibundle.lua#L327-L333 Weirdly enough, [the same thing that affected Lit a while back](https://github.com/luvit/lit/issues/184#issuecomment-228330307)...