Ryan Liptak
Ryan Liptak
Stalled due to https://github.com/MinecraftForge/CoreMods/issues/26
Yeah, would probably just skip to 1.15 at this point. Still effectively blocked by https://github.com/MinecraftForge/CoreMods/issues/26 though.
Fabric port would definitely not have the same problem. I'm not very involved in Minecraft modding anymore, and at this point am basically just updating my existing mods to newer...
Looking good, thanks for doing this @Parker8283. Some notes: - One subtle thing that AppleCore does is fix the animation when eating speed is increased. Not sure if this is...
Sounds good. From what I remember, it only affected the eating/drinking animations for some reason, but I could be wrong about that. Or, perhaps the bug affects all items but...
Ok, details on the animation stuff: - Forge adds a hook for `ForgeEventFactory.onItemUseStart` in `LivingEntity.setActiveHand` and then uses the returned (modified) duration to set the field `LivingEntity.activeItemStackUseCount` - However, `LivingEntity.getItemInUseMaxCount`...
Thanks for the update, hope it can get merged.
In terms of why AppleCore exists, here's the primary use case it was created to support: - Hunger Overhaul being able to modify how much hunger/saturation foods give - The...
@Parker8283 For the tick period stuff, [`GetRegenTickPeriod` is used in Hunger Overhaul](https://github.com/progwml6/HungerOverhaul/blob/7b701649e31c222763f9f634eb9626d7bf7fec34/src/main/java/iguanaman/hungeroverhaul/module/food/FoodEventHandler.java#L109-L142). Unsure if it could be converted to something that doesn't allow for modification of the tick period. The...
Unfortunately, I don't really agree with the reasoning behind either of those warnings existing, so this is not likely to be fixed.