Ryan Liptak
Ryan Liptak
Circular requires are explicitly allowed and tested for by luvit's `require` module: https://github.com/luvit/luvit/blob/master/tests/test-require.lua#L114-L122 Although the test files [use the old `exports` method of defining a module instead of return](https://github.com/luvit/luvit/blob/master/tests/fixtures/libs/parent.lua), so...
Yeah, I agree that allowing circular requires is weird--I was surprised to see that test when I was porting the `require` tests to `luver`. From what I can tell, circular...
@creationix would you be okay with dropping support for them at this point? They're de-facto not supported, since all of `luvit`'s modules cannot be circularly required (since none of them...
As far as I can tell, [this is where Node sets up stdout/stdin/stderr streams](https://github.com/nodejs/node/blob/master/lib/internal/bootstrap/switches/is_main_thread.js) For writable (stdout/stderr), it [uses either `tty`, `pipe`, or a synchronous `fs` write stream](https://github.com/nodejs/node/blob/9528f953360c34a75b3a89839e71884908c2fe6e/lib/internal/bootstrap/switches/is_main_thread.js#L37-L95). For readable...
This change is a little bit more complicated than it first appears, because Luvit expects `stdout`/`stdin` to always be a raw `uv_stream_t` userdata (`uv_tty_t` or `uv_pipe_t`) throughout its deps. So,...
This is still an issue. When Luvit's require falls back to Lua's, the environment of the required file with have Lua's require, not Luvit's. Simple reproduction: `./main.lua`: ```lua print('require', require)...
> The idea is code written for lua's require expects lua's require. Right, I guess I'm mostly of the opinion that Luvit's require should work exactly like Lua's require in...
I believe that is an outdated usage of luvi. Either of the following methods should work, but the second seems like it fits your use case better. **Method 1** Wrap...
Ah, `lit` installs `luvit` into `deps` differently. It should be: ``` app +-- deps +-- http.lua +-- (etc, all luvit deps should be installed in the root of deps) +--...
Something weird is going on here: - The test right after *also* does a `dns.resolveTxt('google.com')` and that works fine - Changing the test from using `google.com` to using `nodejs.org` fixes...