Ian Harry
Ian Harry
Thanks @elisanitoglia! Looking at the change though, it doesn't look as though this would change anything. Looking back, I think the patch was applied in https://github.com/gwastro/pycbc/commit/a582d867057be64d298b33bcb81fbb594cd61592 as part of a...
@duncanmmacleod The extra 5MB is due to verification data files (ie. run code and check output matches verification files). I think we don't want to ship these in the distribution...
I think I'd rather just have these tests pull the data they need at runtime. This better matches what's done in `examples` where we pull data files from GWOSC (or...
I think that after merging #4107 (which I would like to have merged in any case) any test that needs these data files is going to fail without an internet...
It would be a great test of the new injection infrastructure if you can directly sample from the required GRB distributions with `create_injections` and a suitable config file!
The idea of the new stuff @cdcapano wrote is to avoid having to need codes like `pycbc_dark_vs_bright_injections` and instead have this all encoded in the sampling parameters. So it should...
@pannarale Yes, I think so (but @cdcapano is the expert, so feel free to consult him in Slack). This issues Alex and Tito raise should be fixed in the next...
I suggest to move discussion of the constraint to the Slack.
@a-r-williamson The EMbright stuff doesn't really belong in `tmpltbank` but it was perhaps easiest to put it there while it wasn't used anywhere else. Please feel free to move it...
Any suggestion on what is needed to fix this within PyCBC?