Ian Harry

Results 152 comments of Ian Harry

@MariaAssiduo I don't think I would expect such `.sh` files to be produced? I think the banksim just produces its result file (in ASCII format, if I remember right).

> Well overall I'm not a fan. Do you have a call graph after this change, showing that it resolves the "issue"? Yes, I'll post this below. > I don't...

Call graph before this fix is applied ![image](https://user-images.githubusercontent.com/11438929/166559381-0fbef84f-64dc-425f-bc35-b4c832b7d10a.png)

Call graph after this patch is applied: ![image](https://user-images.githubusercontent.com/11438929/166559459-afafe2fb-5e83-4415-9f94-ea75e8ccc3ce.png)

> > As many (most) people would use the function API by default, for testing etc., I think we should try to avoid this being a blocker. > > I...

The latest patch here should hopefully resolve the `del plan` issue, while being opaque to the end user.

@josh-willis A minimal example of this is the script here: https://github.com/gwastro/pycbc/blob/master/tools/timing/fft_perf.py (the backends kwarg needs removing at lines 69 and 79). Then you can do (on CIT): ``` conda activate...

With the patch applied: ![image](https://user-images.githubusercontent.com/11438929/167316800-ccd5fdf3-c39b-4567-8686-29297f061c24.png) (which still doesn't spend anywhere near as much time executing FFTs as I would like!) The size here is based off of waveforms 128 seconds...

Hi @josh-willis, I just wanted to check if you'd had any chance to look at this. While I do agree that the class-based API should be used for performance-critical applications,...

Hi both, apologies for slow response on this. I should probably preface all this by saying that GPU support in PyCBC is *not* at the level of GPU support in...