Steve Pulec

Results 69 comments of Steve Pulec

Hey, sorry for the shitty bug report. I originally thought the issue was simpler than what it actually appears to be. The file in question is [dateutil/parser](https://github.com/sprintly/dateutil/blob/master/dateutil/parser.py). The encoding is...

Just a heads up that there is a proposed solution for this in https://github.com/gabrielfalcao/HTTPretty/pull/193

Can you let us know what fails? A traceback or something? This pull request hasn't been merged in yet so there is no chance that installing from PyPI will work...

Ah, I think this may have been a regression caused by https://github.com/spulec/freezegun/pull/175 It looks like we are checking the id of the module variables, but this won't catch subclasses: https://github.com/spulec/freezegun/blob/1a6c8144b1d5424fd140c93b247b564bd762cfdf/freezegun/api.py#L92-L93

Closing in favor of https://github.com/spulec/freezegun/issues/202

Thank you for opening this. Your point is very valid. I would like to fix this somehow, but have a few thoughts/questions I'm trying to think through. Any feedback appreciated....

@bryanhelmig happy to accept a fix. Agree with thoughts on 1 and 3. 2 makes me a bit nervous. I fear that this would force the majority of users to...

One thing I didn't realize until now is that our existing support for tz offsets already makes the assumption that we are passing the time for `utc` use. From the...

Yes, open to a PR with a clean merge and tests passing.

Yeah, I agree that we should provide a way for the user to more granularly control which modules are ignored or not. I would prefer a more generic solution though...