Andreas Gohr

Results 357 comments of Andreas Gohr

You're right. A "proper" implementation would require some kind of account IdP mapping with users manually creating these association. The current implementation is simple and reuses what DokuWiki already has...

The plugin already uses a refresh token to refresh the access token when needed. I'm using this plugin with Google oAuth and am basically never logged out. So it would...

> This should at least be documented. agreed. please update the docs as you see fit.

setVal is called on parsing (and then cached) and later again on action submit. We should not validate on parsing as this would destroy placeholders. Placeholder do need to be...

This might be an intended change, possibly related to 2e50371a7a238552f6e74a22d4f9587df7f3dd2e or 703ead5a26a57cd4de03e4a9d978646b01107ee5? If so it should be documented at https://www.php.net/manual/en/migration84.incompatible.php because it may subtly break application's tests relying on the...

Note: for people relying on the old behavior, pre-rounding to a lesser precision first seems to work: ```php $int = round(round($float, 13)); ```

> I cannot find the (old) projects in this GitHub repository Hmm.. it seems projects were disabled in the organization. I enabled them but the projects we had are still...

I won't pretend I fully understand what's happening here, but the code seems isolated and tested well enough to add it for a while (to be dropped when PHP drops...

Hmm interesting. I guess we could fallback to bcmath to handle IPv6 here... though I am not sure how widespread 32bit still is in 2025.

Hmm, having a quick look at the code, it seems like this was actually never implemented and I remembered it wrong!? I do think it would be a good idea...