Andreas Gohr

Results 357 comments of Andreas Gohr

> Words are put into wrong w[x].idx file, because there is strlen function used No. That's irrelevant here. We count bytes not characters.

Most of these extensions are not used in DokuWiki's source code!?

I did a quick check. None of those are part of the repository. Closing this.

@alexdraconian currently all tests fail can you check what's up with that? Also could you add tests for the functionality you're changing here?

The src points to an SVG which by design is scalable into any format. Specifying multiple size is also allowed: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/icons#sizes Are you sure your wiki namespace is actually readable...

Works for me. I added your site and dokuwiki.org in Chrome and both show up correctly:

Hmm okay, it's English becasue my chrome auto-translated your site. But you're right that it is weird that it did not use the configured manifest title. I have no idea...

Sorry, this lib is used in legacy applications, so I want to keep compatibility. Can you adjust your code?

Interestingly enough the issue remains when the image is manually rotated (using jhead -autorot) and image magick is used. Using libgd the image is shown correctly.

The issue is here: https://github.com/dokuwiki/dokuwiki/blob/b50e9b3dfcaf8ab5e06852722e64340b7f0d7275/inc/media.php#L1184-L1201 The method tries to calculate the exact size the thumbnail should be, but does so before the exif rotation (8 = ROTATE_CCW) is taken into...