php
Elevate changes due to php/php-src#14332 to incompatible section
Description
The following code:
<?php
echo PHP_VERSION;
echo "\n";
$float = 213.49999999999997;
$round = round($float, 0, PHP_ROUND_HALF_UP);
var_dump($float);
var_dump($round);
Resulted in this output:
8.4.1
float(213.49999999999997)
float(213)
But I expected this output instead:
8.3.14
float(213.49999999999997)
float(214)
All tested previous releases did produce the expected output.
PHP Version
PHP 8.4.1
Operating System
official docker php:8.4-cli image
This might be an intended change, possibly related to 2e50371a7a238552f6e74a22d4f9587df7f3dd2e or 703ead5a26a57cd4de03e4a9d978646b01107ee5? If so it should be documented at https://www.php.net/manual/en/migration84.incompatible.php because it may subtly break application's tests relying on the old behavior and is a pain to identify.
Note: for people relying on the old behavior, pre-rounding to a lesser precision first seems to work:
$int = round(round($float, 13));
It is documented, but on the Other Changes section: https://www.php.net/manual/en/migration84.other-changes.php
@splitbrain, I haven't checked, but I think this is caused by 703ead5a26a57cd4de03e4a9d978646b01107ee5.
@Girgias, it may be sensible to elevate this change:
The maximum precision that can be handled by round() has been extended by one digit. For example, round(4503599627370495.5) returned in 4503599627370495.5, but now returns 4503599627370496.
to the incompatible section (and maybe to explain more thoroughly). There has been quite some discussion and complaining about it in php/php-src#14332.
I am happy for this to be moved, and I still think this whole round() change was a mistake in the end, even if it did fix some weird edge cases... considering that in the end we are still not using IEEE 754 semantics...
Well, the rounding changes might have been a bit rushed, but considering https://3v4l.org/YbUMA#v8.4.1, I think it doesn't only fix weird edge cases. I mean, I'm telling round() to give me an integral number, but it fails. WTF! Still, we should get rid of the pre-rounding; looks bonkers to me.
Agreed, but considering the discussion for the related RFC had this discussion, and it went nowhere, I don't have high hopes...