Kristofer Karlsson
Kristofer Karlsson
Thanks for the PR, but I am not sure this is the right place to add code for moving futures between different executors. Instead of doing it in the conversion...
@danielnorberg @rschildmeijer
Couldn't you just return `x.thenApply(Function.identity())` instead of `x` to prevent `x` from being completed by the caller?
What about https://docs.oracle.com/en/java/javase/12/docs/api/java.base/java/util/concurrent/CompletableFuture.html#minimalCompletionStage() ? Can't that be used instead?
I think it is a useful feature to easily transform a thrown exception to an exceptional future.
I think that by promoting all exceptions from a specific code path to be part of the future can simplify and unify error handling. I can agree that this is...
Looks good. It breaks compatibility so maybe it we should update pom.xml to reflect that. Annoying to bump major version though. Perhaps we can rename the interface, keep the old...
Without this change, it is possible for one thread to read the size of the TDigest at the same time as it's being updated by the record method. Since TDigest...
One thread does this: `distRef.get().add(..)` Another thread does this: `distRef.get().size()` Having an `AtomicReference `does not prevent `add(..)` from being called at the same time as `size()`
I did not measure, and I am not sure how getCount is used - is it used for anything important?