Kristofer Karlsson
Kristofer Karlsson
Sorry for introducing this regression! I think the best fix would be to switch to this implementation instead: https://github.com/dropwizard/metrics/pull/1656 We can either wait for it to be merged and released...
@malish8632 I've made this PR now to address it: https://github.com/spotify/semantic-metrics/pull/87
This fixes it for me: https://github.com/spotify/java-hamcrest/pull/35
Though that PR doesn't really address the root issue... If I add `assertFalse(Thread.currentThread().isInterrupted());` as the first line of each test, it fails on that itself. Thus, I think it's a...
Proper fix here instead: https://github.com/spotify/java-hamcrest/pull/37
Thanks for the issue! For me it would be easiest to think about this once the PR is prepared for review. It sounds reasonable to me now, but perhaps there...
No, sorry. Looks like you have implemented this shading in your fork - you could perhaps submit a PR here with the same shading configuration?
Thanks for the report! It sounds it's possible that the old clients are still trying to reconnect. I'll investigate it further.
Actually... looks like this is intentional. When reconnecting, there's a 60 second shutdown delay by default: https://github.com/spotify/folsom/blob/master/folsom/src/main/java/com/spotify/folsom/ketama/SrvKetamaClient.java#L206 You can reconfigure the shutdown delay if you want.
I'll look into how much work it would be to introduce pending shutdowns and silence the logs for those.