helm-charts
helm-charts copied to clipboard
spiffe
Helm charts for SPIRE and other SPIFFE components.
https://github.com/spiffe/helm-charts/actions/runs/5079875115
Ingress support provided by #68 is a great addition to our deployment charts. The next step is to provide easy to follow instructions on setting up the Ingress in various...
In the glossary, the word "Release" is missing. It's missing because there were two "release" definitions, each meaning wildly different things, depending on what context it was being used in....
To improve documentation of the values, we should include some comments in the style `# -- description of value` to document the different values in the charts. See https://github.com/norwoodj/helm-docs for...
As the project grows the chances are the charts for each component might need to evolve individually. If instead of forcing the "subcharts" pattern they are managed/versioned as individual charts...
We might want to consider revising the designed setup of testing the helm-chart. It seems chart-testing allows to define a ci folder within the chart to define the value overrides...
To ensure contributors have read the CONTRIBUTING.md it would be good to have a PR template that adds following at a minimum: ```md Please describe the changes of your PR...
It might be good to run a cronjob with our tests against the nightly builds so we can see if upstream introduces any new breakages before they cut a release.
To get more safetynets in place it might make sense to add a couple of tests to: charts/spire/charts/spire-agent/templates/tests. What would be a useful testcase here?