Spencer Gilbert

Results 126 comments of Spencer Gilbert

Without totally being aware of the use-case here, this would likely return the name of Vector's pod when running in kubernetes.

If they're using the default Helm chart - we inject the actual node's name as a variable: https://github.com/vectordotdev/helm-charts/blob/develop/charts/vector/templates/_pod.tpl#L53-L56 This seems to be the generally suggested method, otherwise there's API calls...

> > Quick notes - this is missing the markdown file in `website/content/en/docs/reference/configuration/sources/` that provides the documentation scaffolding on the site right now. > > Ohh I saw #13753 ,...

If we're considering adding a `compatibile_version` option, we should consider folding [suppress_type_name](https://vector.dev/docs/reference/configuration/sinks/elasticsearch/#suppress_type_name) into that as well as it's used for compatibility reasons as well. Going even _further_ we should be...

Hi @xdatcloud thanks for the contribution! I'm wondering if there's any advantage to support both JSON and Proto, and if we should just wholly switch to Proto with optional compression....

> > Hi @xdatcloud thanks for the contribution! I'm wondering if there's any advantage to support both JSON and Proto, and if we should just wholly switch to Proto with...

Apologies for the long review cycle. @tobz you've been closer to the technical changes, so if you think those are good to merge thats a 👍 from me. However, it...

Also remembered https://github.com/vectordotdev/vector/issues/13209 needs to be addressed - and it looks like we copy it to the same place for debs?

> > Also remembered #13209 needs to be addressed - and it looks like we copy it to the same place for debs? > > I think it's ok to...