Spencer Gilbert
Spencer Gilbert
Thanks for the contribution @Ilmarii - it struck us that this could also be a good opportunity to switch to `crc32fast` to improve performance here as well (while we're doing...
> Hi! Yes, I think I can integrate `crc32fast` here. Awesome, thanks so much! Please let us know if you need a hand or need to hand over the PR...
👍 thanks y'all - I'll try give this a review before the end of day today, Tuesday at the latest.
Just started reviewing this, and playing with it locally @everpcpc The integration test is currently failing: ``` failures: sinks::databend::integration_tests::insert_events test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured;...
> It seems `Integration - Linux, datadog-*` are always failing since they cannot get secrets when running on forks. Maybe we should separate these to another workflow, or ignore them...
> > Server { code: 507, message: "Presigned Upload Failed" } > > This error seems from MinIO. I could add a more detailed log to see what happened. Maybe...
😅 I wish docker for mac was easier to use... Might need to take another look at colima.
Hi @chidambaranathan-karthikeyan - can you share your complete config, redacting anything sensitive?
Just checking @dizlv - this is still WIP and doesn't necessarily need a review until you Ready it?
Awesome! I've added it to be todos, hopefully will get to it by tomorrow.