Sparsh Goenka
Sparsh Goenka
I would have fixed it already instead of creating this issue 😅. I would need to understand more of your codebase to implement this I think.
Also, it would be nice if you could add some things to contributing.md about how your project simulates the components, like how the updating of circuit is handled or maybe...
Its running fine for me (on macos though).
imo we can have `pattern_matching = "globs"` by default added in config and if someone wants to use regex, they can change it to `pattern_matching = "regex"`
Makes sense, I will default it to do a `use_regex_matching = True` by default for now
Ready to merge, can show a warning if `use_regex_matching` isn't detected in the config, stating that default behaviour would be matching globs from the next major release
`--exclude` cli parameter doesn't work, I will fix that before I can do validation
I have made some changes, `--exclude` parameter now works. `exclude_paths` parameter gets extended with `project_config.exclude` only inside `cli.py` and also gets validated there. Example validation error: > Invalid regex pattern:...
Ready to review, in 2e17a87 I had tried to fix `--exclude` by adding cli excludes to project config. 62cf8a5 reverts this decision, because excludes from project config should be imo...
The pattern validation is not done in `tach_check_external()`. It does not take `--exclude` from cli, is this meant to be there? I will handle validation accordingly then.