Slavi Pantaleev

Results 202 comments of Slavi Pantaleev

`ansible-lint` broke for unknown reasons. Here's one PR where you could see it failing: https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1521 It also wasn't terribly helpful, so it didn't seem like something to bother over. I...

I'm fine with having lint, syntax checking, etc. The problem I have with them is that: - what we've had until now wasn't stable. It breaks with false-positives and annoys...

> Earlier, I was thinking of testing it with vagrant, but how to test various parameters/scenarios and how to verify it is not clear yet. It would be great if...

![Screenshot_20220210_163229](https://user-images.githubusercontent.com/388669/153428956-896ca3a0-56f9-495b-8212-c09788636c76.png) I did a poll in our [#matrix-docker-ansible-deploy:devture.com](https://matrix.to/#/#matrix-docker-ansible-deploy:devture.com) Matrix room for 4.5 hours and here are the results. Looks like Ubuntu and Debian are tied for the 1st place, at...

Yes, I also think it's good to be able to test things locally, without having to push and wait for some magic to test things for you. In the spirit...

I've added some issue template to start with in 4f1423365e6f1221016a87ce1de156d33984b5f7, 85a47d645d81e0f24f83c0cc39aca118f04b10c0 and 238838c31b47b51946235d9b7be4e1ad9997c7c3. [Adding a CONTRIBUTING file](https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#adding-a-contributing-file) will require some more thought though.

I've taken your config and put in in my `vars.yml`, re-ran the playbook (well, even just this part - `ansible-playbook -i inventory/hosts setup.yml --tags=setup-mautrix-signal`) and now I can see that...

This PR is huge and changes lots of unrelated things. A lot of these changes are dubious: - `docker stop` instead of `docker kill`. I guess you did it because...

You can fork this project and make your own branch there. This PR is very outdated now anyway and likely not a great way to approach things nowadays.

Looks like you're correct! A PR is welcome