Soustab Haldar
Soustab Haldar
@possumbilities please review this PR. Thank you.
> @soustab10 Thanks for working on this! I see you used a new dependency `vee-validate`. This project already needs some pairing back on how many dependencies its utilizing. So I'm...
> @soustab10 It looks like your project isn't passing the checks, can you investigate and verify? yes, absolutely.
@possumbilities the module `@creativecommons/cc-assets` is being read as undefined, causing the build to fail. I am trying to fix this asap.
@Cronus1007 I have removed the vee-validate dependency completely.
Thank you @Cronus1007 . What did you change?
> @soustab10 I just used the package-lock.json that is into the `main` branch of Chooser codebase. Okay thanks a lot! Do I need to make any further changes?
> @soustab10 looks like there's still changes requested pending? I have made the changes requested via this [commit](https://github.com/creativecommons/chooser/pull/456/commits/5d73a6191a8e61bf28254be0fd846a2bd602fbe2)
> @soustab10 Thanks for the contribution 💯 @possumbilities LGTM Thanks a lot! Hoping to make more contributions!
> @soustab10 Everything is appearing to be fine for me.Am I missing something? I think the scroll action while the modal is active degrades the user experience. What do you...