chooser icon indicating copy to clipboard operation
chooser copied to clipboard

Disable scroll on body of website when modal is active.

Open soustab10 opened this issue 1 year ago • 4 comments

Description

When a modal is active, scrolling is still active on the body of the website - which is not particularly a good user experience. It is particularly noticeable in [the terms and intended legal effect of CC0,] modal under Waiver Your Copyright.

Reproduction

  1. Step 1: Go to website .
  2. Step 2: Click on any question under CONFUSED? NEED HELP? section.
  3. Scroll and see error.

Expectation

The body should stay fixed when any modal is open.

Screenshots

https://user-images.githubusercontent.com/95632583/227338180-629afddb-75d6-42d4-89e2-e3251e13c454.mp4

Environment

  • Device: Desktop Screens

Resolution

  • [x] I would be interested in resolving this bug.

soustab10 avatar Mar 23 '23 20:03 soustab10

@soustab10 Everything is appearing to be fine for me.Am I missing something?

Cronus1007 avatar Mar 23 '23 21:03 Cronus1007

@soustab10 Everything is appearing to be fine for me.Am I missing something?

I think the scroll action while the modal is active degrades the user experience. What do you think of it?

soustab10 avatar Mar 23 '23 21:03 soustab10

@soustab10 - https://github.com/creativecommons/chooser/pull/482 Made this PR to resolve this issue and disable scroll when the modal gets active.

SADIK112 avatar Apr 04 '23 18:04 SADIK112

if this issue is not fixed i want to fix this can you please assign me this issue?

nik132-eng avatar Dec 03 '23 01:12 nik132-eng