Sukkyu Chung

Ha, things could get a little too complicated depending on the existence of `players` on a condition. If every condition specifies `players` field (i.e., players.length > 0), then the result...

> However, these should not apply when they are optional! > Sorry, I missed this when reviewing the previous PR, but all the cases where the opposing player is awarded...

Yes exactly. So I added this if statement temporarily in `checkWinCondition` in my local env: ```ts if ( condition.type !== WinCriteria.Default && condition.optional && condition.completed?.has(player) ) { return false; }...

> The game should also only end if there is no other way for player1 to win, ie. there are no other win conditions without players or without player1 being...

> In Objective.tsx, add another section next to where we are checking for optional objectives on whether any of the optional conditions was denied. Maybe I'm missing something here, but...

@snowystinger Thanks for the detailed comment. I like the workaround you suggested! I also like the idea of `useForm()`, and if I'm not mistaken it sounds like something that can...

Hm, seems like using `onKeyCapture` to capture `e.target` that is not the submit button also doesn't work when I did a quick test on the story. By the time the...

@yihuiliao haha it's okay! Thanks for letting me know 😄.

Not really related to the issue, but I've found that clicking the disabled button with the MacBook built-in trackpad ('Tap to click' enabled) in the example above doesn't trigger the...