Sukkyu Chung

Results 69 comments of Sukkyu Chung

> so that we can develop against canary since sb7 changed their UI to use the new React render API and React has now removed the old version in canary...

@reidbarber Thanks for the detailed explanation. I appreciate it! > Upgrading storybook to the version that includes that will help. I got a little curious about what React render API...

@snowystinger Thanks for taking time to explain this to me! Forgive my ignorance, but the reason we care about what React render API the Storybook manager is using is because...

> it's a peer dependency https://github.com/storybookjs/storybook/blob/next/code/frameworks/react-webpack5/package.json#L55 & https://github.com/storybookjs/storybook/blob/next/code/renderers/react/package.json#L89 for our parcel framework as well Yeah you're right. A framework (bundler) and a renderer (react) specifying react and react-dom as peer...

> onClick is not triggered on parent when clicking a child onPress or onPressStart with continuePropagation. As far as I can tell, only `PressEvent` handlers of the parent (a 'pressable'...

I was also looking into this issue at the moment, and realized [PopoverWrapper](https://github.com/adobe/react-spectrum/blob/main/packages/%40react-spectrum/overlays/src/Popover.tsx#L88) was being rendered too many times (this can be verified with [React Developer Tools](https://chromewebstore.google.com/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi)). And this infinite...

Correct me if I'm wrong, but this issue is only a problem when _both_ `allowsCustomValue` and `allowsEmptyCollection` are specified, right? I've noticed that if only `allowsCustomValue` is set, then the...

> After finding that it is because of the scale animation If anyone uses [tailwindcss](https://tailwindcss.com/) for styling, you might be able to work around this by specifying a fixed width...

@snowystinger Hi, I happened to look at the code sandbox, and it seems like the root cause of the modal not closing is rather the improper usage of animation named...

I'm sorry that the link didn't work as expected for you.. I must have done something wrong to share the sandbox, but weirdly I'm perfectly fine with the link (even...