Sukkyu Chung

Results 69 comments of Sukkyu Chung

@cpojer Hey, I was reading the issue description again, and was wondering about this part: > and [validateMap](https://github.com/nkzw-tech/athena-crisis/blob/main/athena/lib/validateMap.tsx) (or maybe validateWinCondition or similar) needs to reset the completed state. I'm...

@devongovett I get that revealing the data can be very distracting especially when placed at the top. But at the same time, wouldn't users expect the example code to just...

> I left a few comments – am I right in assuming the biggest challenge is making sure which players to check for denied conditions? What else do you think...

> Would you mind updating the tests? I guess the charge values have been updated? This is done in 2bdeb16

> Ideally the validation for this win condition should verify that the number of optional conditions defined for the map is higher or equal to the "amount" specified on the...

Could you also update the link below? 🙏 > Most likely the new win condition needs to be checked right here: https://github.com/nkzw-tech/athena-crisis/blob/main/apollo/GameOver.tsx#L172 instead of in checkWinCondition. Also, what if I...

> I'm not 100% sure if it will work right away. If it does, great, let's do it. If not, you'll probably need to call checkWinConditions(previousMap, activeMap, optionalObjective) in the...

```ts test('optional objective amount', async () => { const v1 = vec(1, 1); const v2 = vec(1, 2); const v3 = vec(2, 1); const v4 = vec(2, 2); const initialMap...

> I would expect in that case that the game ends and player1 loses (or rather player2 wins). Got it. So eventually in that scenario, player2 should win since there's...

> player2 shouldn't be awarded with an objective if it doesn't apply to them and they denied it for somebody else. Yeah sorry I asked that question because I was...