Son HO comments

Results 111 comments of


                                            Son HO

Memory leaks

Thanks for the remark: it is a mistake and I'll push a fix soon.

Memory leaks

The following PR has just been merged and should fix the issue: https://github.com/project-everest/hacl-star/pull/347 @wintersteiger please tell me if it does('nt) so that I can close the issue.

Memory leaks

Thanks for the feedback! I'll have a look to check for forgotten calls to `free` in other places

Add support for ADTs with lifetimes

Yes, we don't support ADTs with lifetimes for now (I intend to lift this soon). Also, on the shorter term: we're about to start an overhaul of Aeneas to have...

Add support for closures

Thanks for the report: I should have opened an issue for this myself actually. We did a lot of work in Charon to properly extract closure information, and make this...

chore: explain a Nix-powered workflow

What was the issue exactly?

chore(*): add pre-commit hooks for formatting

In practice what does this do? It only uses pre commit hooks if you're using nix, right? If that's the case and you consider it's idiomatic when using nix, I'm...

Failure when extracting a loop with a shared borrow

Slightly minimized example: ```rust struct AVLNode { child: Option, } struct AVLTreeSet { root: Option, } impl AVLNode { pub fn find(self) -> bool { let mut current_tree = &self.child;...

Do not use the `Result` type for functions which syntactically never fail

@msprotz @R1kM I'm interested in your feedback.

Do not use the `Result` type for functions which syntactically never fail

@zhassan-aws you might be interested in this