aeneas icon indicating copy to clipboard operation
aeneas copied to clipboard

chore(*): add pre-commit hooks for formatting

Open RaitoBezarius opened this issue 1 year ago • 2 comments

This adds pre-commit hooks for formatting, because I usually just trust whatever people prefer locally :). We could add, e.g. rustfmt, but I prefer @sonmarcho that you tell me what you prefer regarding this. Pre-commit hooks can be pesky and annoying.

Signed-off-by: Ryan Lahfa [email protected]

RaitoBezarius avatar Apr 24 '24 09:04 RaitoBezarius

We recently added CI checks for formatting, this makes a lot of sense. Could you do the same (with rustfmt also) on Charon's side?

Yes, of course!

RaitoBezarius avatar Apr 24 '24 09:04 RaitoBezarius

In practice what does this do? It only uses pre commit hooks if you're using nix, right? If that's the case and you consider it's idiomatic when using nix, I'm fine.

sonmarcho avatar Apr 24 '24 15:04 sonmarcho

Now that my editor formats everything automatically I'm not longer keen on having this

Nadrieril avatar Jun 04 '24 13:06 Nadrieril

This PR seems dead, so I'm closing it. Feel free to reopen it if you really want this feature.

sonmarcho avatar Jun 30 '24 11:06 sonmarcho